Add trailing commas (closes #37)#46
Merged
NathanLovato merged 3 commits intoGDQuest:mainfrom Sep 19, 2025
Merged
Conversation
Contributor
|
It's great, thanks, and good call adding them to be anywhere where the GDScript syntax allows them, even if the style guide doesn't specify it. When something is not specified, we can look for consistency with rules/other cases that are specified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds trailing commas to arrays, dictionaries, enums, function definitions and functions calls. (closes #37)
Trailing commas in function definitions looks fine, but not sure if they are in function calls. I looked through style guide and didn't find anything regarding commas in func definitions and calls.